User talk:Elibarzilay: Difference between revisions
Line 8: | Line 8: | ||
==Sieve vs trial division.== |
==Sieve vs trial division.== |
||
Hi, I note that you just removed the incorrect flags on [[Sieve of Eratosthenes]] without changing the algorithm. If it isn't a true Sieve then the incorrect flag should be put back until the code is updated, or the code removed. The task specifies that a particular algorithm should be used in the finding of primes. Thanks. --[[User:Paddy3118|Paddy3118]] ([[User talk:Paddy3118|talk]]) 14:08, 24 July 2014 (UTC) |
Hi, I note that you just removed the incorrect flags on [[Sieve of Eratosthenes]] without changing the algorithm. If it isn't a true Sieve then the incorrect flag should be put back until the code is updated, or the code removed. The task specifies that a particular algorithm should be used in the finding of primes. Thanks. --[[User:Paddy3118|Paddy3118]] ([[User talk:Paddy3118|talk]]) 14:08, 24 July 2014 (UTC) |
||
Paddy3118: I changed it with an explicit mention of the algorithm, with a mention of the Scala alternative that does the exact same thing (without an incorrect flag) and I also added a reference to the same paper that is cited in the Scala section. |
|||
(Sorry if there's some other way to communicate replies.) |
|||
--[[User:Elibarzilay|Elibarzilay]] ([[User talk:Elibarzilay|talk]]) 14:38, 24 July 2014 (UTC) |
Revision as of 14:38, 24 July 2014
Hi, remember to check the " This is a minor edit" and adding an edit summary - as appropriate when making edits please. Thanks. --Paddy3118 (talk) 19:58, 19 May 2013 (UTC)
Hi. May I ask what would that be? Isn't the purpose of the code is to be as clear as possible in terms of both logic and implementation? --cmpitg
cmpitg: What is this in reference to?
Sieve vs trial division.
Hi, I note that you just removed the incorrect flags on Sieve of Eratosthenes without changing the algorithm. If it isn't a true Sieve then the incorrect flag should be put back until the code is updated, or the code removed. The task specifies that a particular algorithm should be used in the finding of primes. Thanks. --Paddy3118 (talk) 14:08, 24 July 2014 (UTC)
Paddy3118: I changed it with an explicit mention of the algorithm, with a mention of the Scala alternative that does the exact same thing (without an incorrect flag) and I also added a reference to the same paper that is cited in the Scala section. (Sorry if there's some other way to communicate replies.) --Elibarzilay (talk) 14:38, 24 July 2014 (UTC)