Anonymous user
Talk:SEDOLs: Difference between revisions
→R: stretch goal seems ok
(→R: How about adding the checking as a "stretch goal" to the task?) |
(→R: stretch goal seems ok) |
||
Line 23:
::::Hi Danbron; why the change? It seems a good extension to the task, to make it reject badly formed SEDOLs, as a lot of money could ride on its correctness. How about adding the checking as a "stretch goal" to the task? --[[User:Paddy3118|Paddy3118]] 18:50, 1 October 2009 (UTC)
:::::The reversion was due to the fact that the change broke most of the code. I'm fine adding it as "extra credit" that doesn't make most examples "wrong". The examples that provide extra validation could easily break it out as a separate function or call it out comments in the code. (I see calculation and validation as separate concerns that shouldn't be mixed, and would personally separate them into two functions. And I don't feel sorry for anyone that loses money running code he copped from a website, unscrutinized :) --[[User:DanBron|DanBron]] 19:43, 1 October 2009 (UTC)
== '0' checksum ==
| |||