Talk:Cheryl's birthday

From Rosetta Code
Revision as of 07:18, 26 October 2018 by rosettacode>Paddy3118 (→‎Improve tag on Python entry: Moved.)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)

Improve tag on Python entry

I added an improve tag on the Python entry as it does not look or read like idiomatic Python. To avoid an edit war I will sate my reasons:

  1. Commented type annotations read like those from a different programming language.
  2. Use of map/filter over comprehensions.
  3. Use of trivial functions: fst, id, _not, snd, swap
  4. Overwriting a builtin name: id
  5. main() without `if __name__ == "__main__"`
  6. Shares structure and naming with examples from other languages.

It reads like a translation from another language and RC is about idiomatic code. Paddy3118 (talk) 07:14, 26 October 2018 (UTC)